apache / datafusion-ballista

Apache DataFusion Ballista Distributed Query Engine
https://datafusion.apache.org/ballista
Apache License 2.0
1.55k stars 196 forks source link

Cannot build a fresh checkout, configure_me has yanked deps #1042

Open aditanase opened 3 months ago

aditanase commented 3 months ago

Describe the bug

Can't build after checkout, configure_me depends on an yanked version of cargo_toml library.

To Reproduce Steps to reproduce the behavior:

checkout main, cargo build. Result:

error: failed to select a version for the requirement `cargo_toml = "^0.12.0"`
candidate versions found which didn't match: 0.20.4, 0.20.3, 0.20.2, ...
location searched: crates.io index
required by package `configure_me_codegen v0.4.4`
    ... which satisfies dependency `configure_me_codegen = "^0.4.4"` of package `ballista-executor v0.12.0 (/Users/atanase/dev/arrow/datafusion-ballista/ballista/executor)`
    ... which satisfies path dependency `ballista-executor` of package `ballista v0.12.0 (/Users/atanase/dev/arrow/datafusion-ballista/ballista/client)`
    ... which satisfies path dependency `ballista` of package `ballista-cli v0.12.0 (/Users/atanase/dev/arrow/datafusion-ballista/ballista-cli)`
if you are looking for the prerelease package it needs to be specified explicitly
    cargo_toml = { version = "0.19.0-beta.1" }

Tried a soft update by patching the config with this PR: https://github.com/Kixunil/configure_me/pull/61/files

But now I get other errors which I don't know how to debug.

error: failed to run custom build command for `ballista-executor v0.12.0 (/Users/atanase/dev/arrow/datafusion-ballista/ballista/executor)`

Caused by:
  process didn't exit successfully: `/Users/atanase/dev/arrow/datafusion-ballista/target/debug/build/ballista-executor-855ae22fe006e311/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-changed=executor_config_spec.toml

  --- stderr
  Error: "configure_me code generation failed: failed to parse config specification: invalid type: sequence, expected a map for key `switch` at line 163 column 1"
warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `ballista-scheduler v0.12.0 (/Users/atanase/dev/arrow/datafusion-ballista/ballista/scheduler)`

Caused by:
  process didn't exit successfully: `/Users/atanase/dev/arrow/datafusion-ballista/target/debug/build/ballista-scheduler-296d85212e3c693f/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-changed=scheduler_config_spec.toml

  --- stderr
  Error: "configure_me code generation failed: failed to parse config specification: invalid type: sequence, expected a map for key `switch` at line 186 column 1"

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

aditanase commented 3 months ago

@aditanase we can close when the upstream PR gets merged https://github.com/Kixunil/configure_me/pull/62

Kixunil commented 2 months ago

You should be able to upgrade already. That PR is against master and I've already released a backported version. (master contains some API breaks) Though that version is only using 0.13+ because I made a mistake. It also inevitably bumps MSRV.