apache / datafusion-ballista

Apache DataFusion Ballista Distributed Query Engine

https://datafusion.apache.org/ballista

Apache License 2.0

1.56k stars 197 forks source link

refactor: consolidate ballista tests #1129

Closed milenkovicm closed 2 days ago

milenkovicm commented 2 days ago

there was a bit of repeatibility in the test, same tests were used for standalone and remote context.

this PR introduces:

rstest to parametrise tests, so we can re-use tests for standalone and remote
enable previously ignored tests due to unsupported functionality (like INSERT INTO) to catch if datafusion brings new changes
testcontainers tests moved to example to reduce duplication (~~they are still disabled as i could not make them connect to docker deamon~~)

Which issue does this PR close?

Closes none.

Rationale for this change

simplification and de-duplication of tests

What changes are included in this PR?

rstest to parametrise tests, so we can re-use tests for standalone and remote
enable previously ignored tests due to unsupported functionality (like INSERT INTO) to catch if datafusion brings new changes
testcontainers tests moved to example to reduce duplication (~~they are still disabled as i could not make them connect to docker deamon~~)

follow up PR will move files to centralised location as there may be few duplicates

Are there any user-facing changes?

No, just tests