search

apache / datafusion-ballista

Apache DataFusion Ballista Distributed Query Engine
https://datafusion.apache.org/ballista
Apache License 2.0
1.46k stars 185 forks source link

Fix nodejs issues in Docker build #731

Closed jnaous closed 1 year ago

jnaous commented 1 year ago

Closes #717

Fixes the issue by installing the right version of nodejs.

paolorechia commented 1 year ago

LGTM - I didn't test this though :)

kylebrooks-8451 commented 1 year ago

@r4ntix Can we merge this? I was hoping to get the docker build to run again.

jnaous commented 1 year ago

Waiting for a committer... perhaps @andygrove?

r4ntix commented 1 year ago

@r4ntix Can we merge this? I was hoping to get the docker build to run again.

Sorry, I don't have permission to merge the PR.

@andygrove @yahoNanJing @Ted-Jiang Could you help review it?

avantgardnerio commented 1 year ago

It looks like it did fix it, and the checks passed in the branch, but it failed when merged to main:

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@1.1.7" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@2.0.5" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
warning " > @testing-library/user-event@12.8.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
[4/4] Building fresh packages...
Done in 37.20s.
yarn run v1.22.1[9](https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:5:10)
$ react-scripts --openssl-legacy-provider build
/usr/bin/node: bad option: --openssl-legacy-provider
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 9.

Does anyone know why that error might be happening there?

paolorechia commented 1 year ago

Hi, @avantgardnerio, my first hunch is that the installed node version does not match what we expect (18)

If I’m not mistaken, this OpenSSL flag is added to node 17+

When peeking at the build logs, I saw this (nodejs v12):

https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:4:1079

I hope I read it correctly, hard to search the logs in my mobile phone :)

avantgardnerio commented 1 year ago

Hi all, PTAL at https://github.com/apache/arrow-ballista/pull/794 since this seems like it will fix the build.