search

apache / datafusion-ballista

Apache DataFusion Ballista Distributed Query Engine
https://datafusion.apache.org/ballista
Apache License 2.0
1.39k stars 181 forks source link

feat: make max message size configurable for gRPC clients #983

Closed etolbakov closed 4 months ago

etolbakov commented 4 months ago

Which issue does this PR close?

Closes https://github.com/apache/arrow-ballista/issues/930 Relates to https://github.com/apache/arrow-ballista/pull/931

Rationale for this change

Make max message size configurable for gRPC clients.

What changes are included in this PR?

Updated BallistaConfig code and adjusted tests

Are there any user-facing changes?

no

etolbakov commented 4 months ago

@andygrove Could you please take a look when you have time?

Two main questions that I have: 1) the naming convention for the config keys (should it be . or _ separated). Please let me know if any adjustments should be made. 2) failed to find if distributed_query.rs, executor_process.rs, executor_server.rs are using BallistaConfig in order to apply the same change that I did for context.rs. Does the scope of this PR is suppose to add config as well?

andygrove commented 4 months ago

I started looking at your question 2 and I think it will be easiest for me to put up a PR to explain. I should have that up shortly.