search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

fix: Make comet-git-info.properties optional #1027

Closed andygrove closed 1 month ago

andygrove commented 1 month ago

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/1026 Closes https://github.com/apache/datafusion-comet/issues/1012

Rationale for this change

Our instructions for building from source produce a jar file that does not contain comet-git-info.properties and this results in an exception at runtime.

We had the same issue with our Docker build because that also builds without git info.

What changes are included in this PR?

Use default values in CometBuildInfo instead of throwing an exception if comet-git-info.properties does not exist.

How are these changes tested?

I tested manually using our Docker/k8s instructions. This was previously failing for me.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (e3ac6cf) to head (6979696). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...mmon/src/main/scala/org/apache/comet/package.scala 0.00% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1027 +/- ## ============================================ - Coverage 34.41% 34.28% -0.13% + Complexity 886 881 -5 ============================================ Files 112 112 Lines 43479 43477 -2 Branches 9656 9648 -8 ============================================ - Hits 14962 14908 -54 - Misses 25442 25480 +38 - Partials 3075 3089 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.