search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

fix: TopK operator should return correct results on dictionary column with nulls #1033

Closed viirya closed 4 weeks ago

viirya commented 4 weeks ago

Which issue does this PR close?

Closes #1030.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

viirya commented 4 weeks ago

cc @huaxingao With this patch, the failed Iceberg test can pass now.

andygrove commented 4 weeks ago

I ran TPC-H benchmarks comparing this PR to main and did not see any regression

viirya commented 4 weeks ago

Thanks @huaxingao @andygrove