search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

chore: Refactor Arrow Array and Schema allocation in ColumnReader and MetadataColumnReader #1047

Closed viirya closed 2 weeks ago

viirya commented 3 weeks ago

Which issue does this PR close?

Closes #1048.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 25.71429% with 26 lines in your changes missing coverage. Please review.

Project coverage is 34.32%. Comparing base (3df9d5c) to head (7d7f388). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/org/apache/comet/parquet/ColumnReader.java 0.00% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1047 +/- ## ============================================ + Coverage 34.28% 34.32% +0.03% - Complexity 881 887 +6 ============================================ Files 112 113 +1 Lines 43478 43588 +110 Branches 9648 9647 -1 ============================================ + Hits 14908 14963 +55 - Misses 25481 25552 +71 + Partials 3089 3073 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viirya commented 2 weeks ago

Thanks @kazuyukitanimura