search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

feat: Implement CAST between struct types #1074

Closed andygrove closed 1 week ago

andygrove commented 1 week ago

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/815

Rationale for this change

We need support for casting between struct types to support reading structs from Parquet using DataFusion's ParquetExec.

What changes are included in this PR?

How are these changes tested?

andygrove commented 1 week ago

@parthchandra @mbutrovich could you review?

We need more extensive tests for sure, but it will be easier to add those as part of the comet-parquet-exec feature branch.

viirya commented 1 week ago

We need more extensive tests for sure, but it will be easier to add those as part of the comet-parquet-exec feature branch.

Spark should have many Cast expression tests. As we pass Spark tests, it should be fine for general cases.