fix: Unsigned type related bugs - Githubissues

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator

https://datafusion.apache.org/comet

Apache License 2.0

823 stars 163 forks source link

fix: Unsigned type related bugs #1095

Closed kazuyukitanimura closed 2 days ago

kazuyukitanimura commented 3 days ago

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/1067

Rationale for this change

Bug fix. A few expressions were failing some unsigned type related tests

What changes are included in this PR?

For u8/u16, switched to use generate_cast_to_signed! in order to copy full i16/i32 width instead of padding zeros in the higher bits
u64 becomes Decimal(20, 0) but there was a bug in round() (> vs >=)

How are these changes tested?

Put back tests for unsigned types

kazuyukitanimura commented 2 days ago

Merged, thanks @andygrove @viirya