Closed advancedxy closed 2 months ago
Attention: Patch coverage is 15.70513%
with 263 lines
in your changes are missing coverage. Please review.
Project coverage is 33.36%. Comparing base (
aa6ddc5
) to head (fb49a88
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Gently ping @sunchao and @viirya
Sorry for the delay @advancedxy . I'll try to take a look soon.
@sunchao would you mind to take a look at this again, I should address most of your comments, please let me know if you have any other comments.
And sorry for the late update, I wasn't feeling well last week.
Merged, thanks @advancedxy ! If any comments from @viirya are not addressed, we can do it in a separate PR. This PR has been open for too long :)
If any comments from @viirya are not addressed, we can do it in a separate PR.
Of course.
Thanks for @sunchao and @viirya's review, really appreciate that.
Which issue does this PR close?
This closes #119 and partially resolves #137
Rationale for this change
For ease testing with RangeExec operator in the short term. In the long term, this PR introduce a general way to enable Comet with row-based source exec nodes
What changes are included in this PR?
CometRowToColumnarExec
to transform Spark's InternalRow into ColumnarBatchHow are these changes tested?