apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
548 stars 105 forks source link

feat: Enable columnar shuffle by default #250

Closed viirya closed 3 weeks ago

viirya commented 1 month ago

Which issue does this PR close?

Closes #95.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 33.50%. Comparing base (9ab6c75) to head (ace91fe). Report is 9 commits behind head on main.

Files Patch % Lines
.../scala/org/apache/spark/sql/comet/util/Utils.scala 0.00% 2 Missing :warning:
...ain/scala/org/apache/comet/vector/NativeUtil.scala 0.00% 1 Missing :warning:
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #250 +/- ## ============================================ + Coverage 33.47% 33.50% +0.03% - Complexity 795 798 +3 ============================================ Files 110 110 Lines 37533 37541 +8 Branches 8215 8217 +2 ============================================ + Hits 12563 12579 +16 + Misses 22322 22321 -1 + Partials 2648 2641 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viirya commented 1 month ago

Hmm, all tests in TPCDSQuerySuite` are passed locally with this PR. I need to look at the CI failure.

viirya commented 1 month ago

Observed several Spark SQL test failures regarding aggregation: #260

viirya commented 3 weeks ago

I fixed all Spark SQL test failures. Now waiting for #380 to be merged.

viirya commented 3 weeks ago

cc @sunchao @andygrove

viirya commented 3 weeks ago

@andygrove @sunchao Could you take a look and see if you have any comments on this? Thanks.

viirya commented 3 weeks ago

Thank you @andygrove

viirya commented 3 weeks ago

Merged. Thanks @andygrove for review.