[EPIC] Support try_* functions which always return NULL instead of runtime errors - Githubissues

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator

https://datafusion.apache.org/comet

Apache License 2.0

646 stars 119 forks source link

[EPIC] Support try_* functions which always return NULL instead of runtime errors #280

Open advancedxy opened 2 months ago

advancedxy commented 2 months ago

Spark adds a lot of try_* functions in the recent two years, which always return NULL instead of runtime errors. The list is as follows:

[ ] try_add
[ ] try_divide
[ ] try_subtract
[ ] try_multiply
[ ] try_element_at
[ ] try_avg
[ ] try_sum
[ ] try_to_binary
[ ] try_to_timestamp
[ ] try_aes_decrypt
[x] ~~try_reflect~~ (cannot be supported in Comet?)
[ ] try_cast (part of https://github.com/apache/datafusion-comet/issues/286)

We should add support to these functions too. It could be implemented in Comet first then contributed back to upstream DataFusion.

_Originally posted by @viirya in https://github.com/apache/arrow-datafusion-comet/pull/277#discussion_r1568139442_

andygrove commented 2 months ago

I added try_cast to the list, with a link to the cast epic