apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
447 stars 100 forks source link

feat: Disable cast string to timestamp by default #337

Closed andygrove closed 2 weeks ago

andygrove commented 2 weeks ago

Which issue does this PR close?

Related to https://github.com/apache/datafusion-comet/issues/328

Rationale for this change

Casting from string to timestamp can cause incorrect results especially regarding timezone and could potentially lead to data corruption. We should disable it by default until we have fixed https://github.com/apache/datafusion-comet/issues/328

What changes are included in this PR?

How are these changes tested?

New test added