chore: Add more cast tests and improve test framework - Githubissues

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator

https://datafusion.apache.org/comet

Apache License 2.0

447 stars 100 forks source link

chore: Add more cast tests and improve test framework #351

Closed andygrove closed 2 weeks ago

andygrove commented 2 weeks ago

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/286

Rationale for this change

Get a better idea of which casts are failing.

What changes are included in this PR?

Add test to make sure we have coverage for valid cast combinations
Add tests to cover all cast operations supported by Spark (for the data types we currently support). Some of the tests are ignored and/or contain TODO statements
Bring in some framework improvements from pending PRs

How are these changes tested?

New tests

andygrove commented 2 weeks ago

Thanks for the review @kazuyukitanimura. I have addressed your feedback. Could you take another look?