search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
447 stars 100 forks source link

fix: SortMergeJoin with unsupported key type should fall back to Spark #355

Closed viirya closed 2 weeks ago

viirya commented 2 weeks ago

Which issue does this PR close?

Closes #354.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

viirya commented 2 weeks ago

cc @sunchao @andygrove

planga82 commented 2 weeks ago

As an idea, I was thinking that we could put in tests to check the supported types in Datafusion, so that when we upgrade to a version of datafusion that supports these other types (like timestamp with timezone for example) we are aware that we should change the list of allowed types.

viirya commented 2 weeks ago

Merged. Thanks.

viirya commented 2 weeks ago

@planga82 Thanks for the suggestion. I created an issue to track it.