search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
447 stars 100 forks source link

Write a guide on contributing a new expression #370

Open andygrove opened 2 weeks ago

andygrove commented 2 weeks ago

What is the problem the feature request solves?

We should write a detailed guide showing new contributors how to add support for a new expression in Comet. This would cover the Scala, Protobuf, and Rust changes, as well as testing approaches. We could create this based on a recent PR that added a new expression.

Describe the potential solution

No response

Additional context

No response

tshauck commented 2 weeks ago

Once https://github.com/apache/datafusion-comet/pull/342 is approved/merged and if it's an appropriate example, I'd be happy to write this based off that work.

parthchandra commented 2 weeks ago

Also related to adding a new expression is adding a new aggregate expression (for example: https://github.com/apache/datafusion-comet/commit/49bf503780dfc93ede968b626214d53fb0953c34)

andygrove commented 2 weeks ago

And I suppose we also need a separate guide on adding cast expressions since there are specific test considerations