Add support for TryCast expression in Spark 3.2 and 3.3

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator

https://datafusion.apache.org/comet

Apache License 2.0

447 stars 100 forks source link

Add support for TryCast expression in Spark 3.2 and 3.3 #374

Closed andygrove closed 2 days ago

andygrove commented 2 weeks ago

What is the problem the feature request solves?

Spark 3.2 and 3.3 has a TryCast expression and Spark 3.4 removed it and added an evalMode parameter to the Cast expression.

We do not support the TryCast expression and should add support. This was missed until now because CometCastSuite calls checkSparkAnswer instead of checkSparkAnswerAndOperator.

Describe the potential solution

No response

Additional context

No response

vaibhawvipul commented 1 week ago

I am working on this one.