apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
611 stars 113 forks source link

build: Add spark-4.0 profile and shims #407

Closed kazuyukitanimura closed 2 weeks ago

kazuyukitanimura commented 1 month ago

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/372

Rationale for this change

To be ready for Spark 4.0

What changes are included in this PR?

This PR adds the spark-4.0 profile and shims

How are these changes tested?

This is an initial commit. Tests with the spark-4.0 profile do not pass yet. Tests for spark-3.x should pass.

kazuyukitanimura commented 1 month ago

@viirya @andygrove Please approve to start CI

viirya commented 1 month ago

Triggered.

kazuyukitanimura commented 1 month ago

@viirya @andygrove Is there a way to start CI without bothering you?

viirya commented 1 month ago

I remember only the first-time contributors need approval to trigger CI.

kazuyukitanimura commented 1 month ago

@viirya @andygrove passed all the tests on my personal github actions It looks still not triggering here. Maybe need a committership to start CI with github actions workflow change?

viirya commented 1 month ago

Triggered CI pipelines.

kazuyukitanimura commented 4 weeks ago

@viirya Please take another look cc @andygrove @comphead

kazuyukitanimura commented 3 weeks ago

Thank you @viirya Please take a final look 32bc314

viirya commented 2 weeks ago

@kazuyukitanimura I think you can try to merge this.

kazuyukitanimura commented 2 weeks ago

Thank you @viirya merged