search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
547 stars 105 forks source link

chore: Make COMET_EXEC_BROADCAST_FORCE_ENABLED internal config #413

Closed viirya closed 3 weeks ago

viirya commented 3 weeks ago

Which issue does this PR close?

Closes #408.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

viirya commented 3 weeks ago

cc @andygrove

andygrove commented 3 weeks ago

lgtm thanks @viirya should we also modify the text saying this param is internal?

I don't think we need to change the description of the config. We just need to make it internal so that it doesn't appear in the public documentation.

viirya commented 3 weeks ago

I don't think we need to change the description of the config. We just need to make it internal so that it doesn't appear in the public documentation.

Yes, I agreed. Thanks @andygrove @comphead