apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
549 stars 105 forks source link

chore: Add cargo bench for shuffle writer #438

Closed andygrove closed 2 weeks ago

andygrove commented 2 weeks ago

Which issue does this PR close?

N/A

Rationale for this change

I would like to profile the shuffle writer code and understand if there are any opportunities for optimizing performance.

What changes are included in this PR?

Screenshot 2024-05-16 at 4 07 34 PM

How are these changes tested?

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.17%. Comparing base (fcf7d5b) to head (f8b3203). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #438 +/- ## ========================================= Coverage 34.17% 34.17% Complexity 850 850 ========================================= Files 116 116 Lines 38547 38552 +5 Branches 8523 8524 +1 ========================================= + Hits 13172 13175 +3 - Misses 22609 22610 +1 - Partials 2766 2767 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andygrove commented 2 weeks ago

Thanks for the review @viirya