search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
547 stars 105 forks source link

chore: improve fallback message when comet native shuffle is not enabled #445

Closed andygrove closed 1 week ago

andygrove commented 2 weeks ago

Which issue does this PR close?

N/A

Rationale for this change

The current message Native shuffle is not enabled is not very informative. There are several configs that need to be set in order for native shuffle to be enabled.

What changes are included in this PR?

Improve the fallback message to explain why native shuffle is not enabled

How are these changes tested?

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 34.02%. Comparing base (fcf7d5b) to head (2dcc472). Report is 8 commits behind head on main.

Files Patch % Lines
...org/apache/comet/CometSparkSessionExtensions.scala 57.14% 1 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ============================================ - Coverage 34.17% 34.02% -0.15% - Complexity 850 858 +8 ============================================ Files 116 116 Lines 38547 38594 +47 Branches 8523 8525 +2 ============================================ - Hits 13172 13132 -40 - Misses 22609 22703 +94 + Partials 2766 2759 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viirya commented 1 week ago

Merged. Thanks @andygrove @advancedxy