Use maven-assembly-plugin to set final artifact name

[andygrove]

What is the problem the feature request solves?

We currently set the artifact name in <artifactId> to include the Spark version and the Scala version:

<artifactId>comet-parent-spark${spark.version.short}_${scala.binary.version}</artifactId>

This is invalid Maven syntax and causes these build warnings:

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.comet:comet-common-spark3.4_2.12:jar:0.1.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-common-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/common/pom.xml, line 33, column 15
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-parent-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/pom.xml, line 27, column 15
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.comet:comet-spark-spark3.4_2.12:jar:0.1.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-spark-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/spark/pom.xml, line 33, column 15
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.comet:comet-spark-integration-spark3.4_2.12:pom:0.1.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-spark-integration-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/spark-integration/pom.xml, line 33, column 17
[WARNING] 'build.plugins.plugin.version' for org.codehaus.mojo:exec-maven-plugin is missing. @ org.apache.comet:comet-spark-integration-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/spark-integration/pom.xml, line 81, column 21
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.comet:comet-fuzz-spark3.4_2.12:jar:0.1.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-fuzz-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/fuzz-testing/pom.xml, line 32, column 17
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.comet:comet-parent-spark3.4_2.12:pom:0.1.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.comet:comet-parent-spark${spark.version.short}_${scala.binary.version}:0.1.0-SNAPSHOT, /Users/andy/git/apache/datafusion-comet/pom.xml, line 27, column 15

We should use the maven-assembly-plugin instead to set the final artifact name based on the build profile used.

Describe the potential solution

No response

Additional context

No response

[parthchandra]

This was taken from Spark which has corrected it since