search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
826 stars 164 forks source link

minor: cast timestamp test #468 #923

Closed himadripal closed 2 months ago

himadripal commented 2 months ago

Removed assume(isspark34Plus). Tested with `make test PROFILES="-Pspark-3.3". 3.2 is not supported. All worked.

Closes #468

himadripal commented 2 months ago

@viirya @andygrove @parthchandra , please take a look.

comphead commented 2 months ago

Thanks @himadripal for your contribution, triggering the workflow

comphead commented 2 months ago

Please fix the PR title, 

Please use a title in the format: type: message, or type(scope): message
Example: feat: Add support for sort-merge join
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.92%. Comparing base (033fe6f) to head (6534a9d). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #923 +/- ## ============================================= + Coverage 34.03% 54.92% +20.88% + Complexity 883 853 -30 ============================================= Files 113 109 -4 Lines 43170 10697 -32473 Branches 9516 2050 -7466 ============================================= - Hits 14693 5875 -8818 + Misses 25471 3789 -21682 + Partials 3006 1033 -1973 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viirya commented 2 months ago

The issue claims that the test fails to pass for Spark 3.2 and 3.3. We don't have 3.2 test but 3.3 is still there. Any change that makes it passed in Spark 3.3 now?