search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
826 stars 164 forks source link

chore: Enable additional CreateArray tests #928

Closed Kimahriman closed 1 month ago

Kimahriman commented 2 months ago

Which issue does this PR close?

Follow up to https://github.com/apache/datafusion-comet/issues/792

Rationale for this change

Enable additional CreateArray tests now that we've bumped the DataFusion version in https://github.com/apache/datafusion-comet/pull/909

What changes are included in this PR?

Enable additional tests, and make on change to the equality check for type coercion to fix one of the new tests.

How are these changes tested?

New tests enabled

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.04%. Comparing base (033fe6f) to head (bd02660). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #928 +/- ## ============================================ + Coverage 34.03% 34.04% +0.01% + Complexity 883 882 -1 ============================================ Files 113 112 -1 Lines 43170 43290 +120 Branches 9516 9553 +37 ============================================ + Hits 14693 14739 +46 - Misses 25471 25537 +66 - Partials 3006 3014 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.