I lost some time today debugging a metrics issue where I thought that metrics were being lost between native and jvm because the calls to add from native did not match the final value in jvm. It was not obvious to me that add was actually calling set and replacing previous values.
Which issue does this PR close?
N/A
Rationale for this change
I lost some time today debugging a metrics issue where I thought that metrics were being lost between native and jvm because the calls to
addfrom native did not match the final value in jvm. It was not obvious to me thataddwas actually callingsetand replacing previous values.What changes are included in this PR?
Rename a method and add some docs.
How are these changes tested?