search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

chore: Change maven group ID to `org.apache.datafusion` #941

Closed andygrove closed 2 months ago

andygrove commented 2 months ago

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/721

Rationale for this change

I am requesting that ASF INFRA sets up Nexus access for the DataFusion project so that we can publish Maven artifacts. The normal convention for maven group ids for Apache projects is org.apache.TLPNAME, so I think we need to revisit changing our Maven group ids ( in the pom.xml) from org.apache.comet to org.apache.datafusion. The DataFusion project could hypothetically want to publish Java bindings to Maven in the future as well. The artifact names would not change and there is no need to change package names in the code.

Note that we did previously discuss this back in https://github.com/apache/datafusion-comet/pull/278.

What changes are included in this PR?

How are these changes tested?

parthchandra commented 2 months ago

@huaxingao This will presumably affect the dependency in iceberg that we are proposing to add.

parthchandra commented 2 months ago

@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this). is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.

andygrove commented 2 months ago

@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this). is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.

I had a brief discussion with ASF infra and they said that the Maven group ID should be org.apache.TLPNAME although there are exceptions to that. If we want to use a different TLPNAME then I think we will need to have a conversation with ASF infra to request an exception.

parthchandra commented 2 months ago

I had a brief discussion with ASF infra and they said that the Maven group ID should be org.apache.TLPNAME

Well, that settles it then.

andygrove commented 2 months ago

Infra also mentioned that we should perform a Podling name search at some point to check whether Comet is allowable as a TLP. Comet components are already in other Apache projects (Apache Tomcat and Apache Tuscany).

https://incubator.apache.org/guides/names.html

huaxingao commented 2 months ago

This will presumably affect the dependency in iceberg that we are proposing to add.

@parthchandra Do I need to change anything on iceberg side?

parthchandra commented 2 months ago

This will presumably affect the dependency in iceberg that we are proposing to add.

@parthchandra Do I need to change anything on iceberg side?

The dependency will change from org.apache.comet:comet-spark to org.apache.datafusion:comet-spark etc