search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
826 stars 164 forks source link

fix: Normalize NaN and zeros for floating number comparison #953

Closed viirya closed 2 months ago

viirya commented 2 months ago

Which issue does this PR close?

Closes #663.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

kazuyukitanimura commented 2 months ago

Related https://github.com/apache/datafusion-comet/pull/585

andygrove commented 2 months ago

@viirya Should there be any update to the documentation, such as the compatibility guide as part of this PR?

viirya commented 2 months ago

@viirya Should there be any update to the documentation, such as the compatibility guide as part of this PR?

Good suggestion. Let me add one.

viirya commented 2 months ago

Thanks @andygrove