search

apache / datafusion-comet

Apache DataFusion Comet Spark Accelerator
https://datafusion.apache.org/comet
Apache License 2.0
823 stars 163 forks source link

fix: div and rem by negative zero #960

Closed kazuyukitanimura closed 1 month ago

kazuyukitanimura commented 1 month ago

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/521 and https://github.com/apache/datafusion-comet/issues/665.

Rationale for this change

What changes are included in this PR?

This PR normalize the right hand of div and rem

How are these changes tested?

Test updated

kazuyukitanimura commented 1 month ago

cc @andygrove @comphead @huaxingao @mbutrovich @parthchandra @viirya

kazuyukitanimura commented 1 month ago

Closes #585

kazuyukitanimura commented 1 month ago

Merged Thank you @mbutrovich @viirya