apache / datafusion-python

Apache DataFusion Python Bindings
https://datafusion.apache.org/python
Apache License 2.0
364 stars 77 forks source link

Merge PyConfig and PySessionConfig #322

Open andygrove opened 1 year ago

andygrove commented 1 year ago

Is your feature request related to a problem or challenge? Please describe what you are trying to do. We have two different config classes, which is confusing.

Describe the solution you'd like There should be one way to set configs

Describe alternatives you've considered

Additional context

mesejo commented 1 year ago

Hey! I see that there is a SessionConfig in the DataFusion main repo (docs here), but I could not find a Config Class.

So I guess that to solve this issue, we need to:

  1. Move the methods that are present in PyConfig but not in PySessionConfig (for example, from_env)
  2. Mark PyConfig as deprecated (notifying users of a future deletion)
  3. Refactor the tests accordingly

Do we need to do anything else?