search

apache / datafusion-python

Apache DataFusion Python Bindings
https://datafusion.apache.org/python
Apache License 2.0
329 stars 64 forks source link

Revert "build(deps): bump arduino/setup-protoc from 1 to 2 (#452)" #474

Closed viirya closed 10 months ago

viirya commented 10 months ago

This reverts commit 944b1c98343aeae3dd6d2d82525a27068d5fb12d.

Which issue does this PR close?

Closes #472.

Rationale for this change

This follows the suggestion from https://github.com/arduino/setup-protoc/issues/85. Based on it, setup-protoc@v2 is for v21.0. We should setup-protoc@v1.

What changes are included in this PR?

Are there any user-facing changes?

viirya commented 10 months ago

The step Install Protoc is passed in these workflows.

viirya commented 10 months ago

cc @alamb @andygrove

alamb commented 10 months ago

I don't know a whole lot about this repo, but the change seems reasonable to me

viirya commented 10 months ago

Thank you @alamb @andygrove