apache / datafusion-python

Apache DataFusion Python Bindings
https://datafusion.apache.org/python
Apache License 2.0
323 stars 64 forks source link

feat: expose PyWindowFrame #509

Closed dlovell closed 8 months ago

dlovell commented 9 months ago

Which issue does this PR close?

Partial progress on #191 : Expressions: Window function

What changes are included in this PR?

This PR

Are there any user-facing changes?

PyWindowFrame needs to be documented as do changes to functions.window

note: I have working code that enables window functions for ibis that I still need to create a PR for

andygrove commented 9 months ago

Build is failing due to new clippy rule in latest Rust. I have a fix in https://github.com/apache/arrow-datafusion-python/pull/511

andygrove commented 9 months ago

@dlovell Could you upmerge to pick up the clippy fix?

dlovell commented 9 months ago

@andygrove i hadn't heard the term upmerge before, but i presume that means merge main into pywindowframe. let me know if i should do something else.

andygrove commented 9 months ago

@andygrove i hadn't heard the term upmerge before, but i presume that means merge main into pywindowframe. let me know if i should do something else.

Yes, exactly.