Closed dlovell closed 8 months ago
Build is failing due to new clippy rule in latest Rust. I have a fix in https://github.com/apache/arrow-datafusion-python/pull/511
@dlovell Could you upmerge to pick up the clippy fix?
@andygrove i hadn't heard the term upmerge before, but i presume that means merge main
into pywindowframe
. let me know if i should do something else.
@andygrove i hadn't heard the term upmerge before, but i presume that means merge
main
intopywindowframe
. let me know if i should do something else.
Yes, exactly.
Which issue does this PR close?
Partial progress on #191 : Expressions: Window function
What changes are included in this PR?
This PR
PyWindowFrame
functions.window
to accept an optionalPyWindowFrame
and optionalPySessionContext
PySessionContext
is necessary to look up aggregates registered viaPySessionContext.register_udaf
function.window
to fall back toSessionContext.udaf
whenfind_df_window_func
failsAccumulator
impl forRustAccumulator
to exposeretract_batch
andsupports_retract_batch
Are there any user-facing changes?
PyWindowFrame
needs to be documented as do changes tofunctions.window
note: I have working code that enables window functions for
ibis
that I still need to create a PR for