apache / datafusion-python

Apache DataFusion Python Bindings

https://datafusion.apache.org/python

Apache License 2.0

356 stars 71 forks source link

Add support for window function bindings #521

Closed jdye64 closed 11 months ago

jdye64 commented 11 months ago

Which issue does this PR close?

Closes #520

andygrove commented 11 months ago

@jdye64 Is there any overlap between this PR and the recently merged PR that added Window Frame bindings?

https://github.com/apache/arrow-datafusion-python/pull/509

jdye64 commented 11 months ago

I had missed that one. Yes, seems to be a lot of overlap. Let me rebase with main and remove the duplicate pieces.

jdye64 commented 11 months ago

I think I'm going to move window_frame.rs into the expr directory since that lines up with arrow-datafusion location and also rename it to just window.rs and include both window and window_frame logic in the single file. Will post the commit here shortly.

andygrove commented 11 months ago

@dlovell fyi