Closed Michael-J-Ward closed 1 month ago
The initial steps are completed and python -m pytest
now passing in #662 (modulo 1, discussed below).
Besides the failing test
SessionContext::tables
is what we want to doallow(deprecated)
from udf.rs
functions.rs
I sketched out some of the upgrade in #662 and wanted to share what I encountered.
Some major changes in between datafusion 36 and 37.
Needs Completing
functions.rs
BuiltInFunctons to datafusion-functionsSectionContext::tables
or updating the tests to not rely on itExecutionPlan
andExecutionPlanProperties
forDatasetExec
need implementing1) Porting BuiltinFunctions
See this epic https://github.com/apache/datafusion/issues/9285.
That means much of
datafusion-python::functions.rs
needs an update. An incomplete first pass is https://github.com/apache/datafusion-python/pull/662/commits/83249fe9a4e809bb6065671bcaee543065d2d3562)
SectionContext::tables
It was removed in https://github.com/apache/datafusion/pull/9627
Many of the tests rely on this method. Does each test get updated to a new API or do we implement our own version to start and then update the tests until it's not necessary?
3) New Trait Methods
I just marked these as
TODO
to get the upgrade to compile. See https://github.com/apache/datafusion-python/pull/662/commits/8cd4fd43c57a8b3fb6733a85da3aac068b73dcd1