Incorporate upstream array_slice fixes - Githubissues

apache / datafusion-python

Apache DataFusion Python Bindings

https://datafusion.apache.org/python

Apache License 2.0

320 stars 63 forks source link

Incorporate upstream array_slice fixes #670

Closed Michael-J-Ward closed 2 weeks ago

Michael-J-Ward commented 1 month ago

Describe the bug Upgrading in #669 discovered a few bugs in datafusion

Blocked on

So we commented out a single failing test to make the tests pass. https://github.com/apache/datafusion-python/pull/669/commits/eeccbfddf8dfb2f3f461e82552b9200cbecb14df

TODO

Once the upstream fixes are available

[ ] re-introduce the test
[ ] (maybe?) provide a nullable default for stride in functions::array_slice