apache / datafusion-python

Apache DataFusion Python Bindings

https://datafusion.apache.org/python

Apache License 2.0

320 stars 63 forks source link

Fix Docs #676

Closed Michael-J-Ward closed 1 month ago

Michael-J-Ward commented 1 month ago

Which issue does this PR close?

Closes #675

Rationale for this change

What changes are included in this PR?

1) Remove offending function call regex_replace from docs. This will be added back once upstream datafusion figures out optional arguments to UDFs. 2) Update the docs github action to run on pull requests but only deploy when it hits main.

Michael-J-Ward commented 1 month ago

Any clues on why Dev / Release Audit Tool (RAT) would have broken from this PR?

comphead commented 1 month ago

Any clues on why Dev / Release Audit Tool (RAT) would have broken from this PR?

There are *.rst files added which not covered by Apache license header. You need either put the generated folder under RAT exclusion or double check if those files needed in the repo

Michael-J-Ward commented 1 month ago

Thanks @comphead. I had included some generated files by accident in one of the commits.