Closed Michael-J-Ward closed 3 days ago
Part of #727 Ref #730
Provides python compatibility for sqlparser::ast::NullTreatment which is now part of the UDAF api.
sqlparser::ast::NullTreatment
AggregateFunction::Sum enum variant is still defined upstream, but can not be used.
AggregateFunction::Sum
I suspect that the proper solution is to register the new UDAFs with the function registry. But I'm unsure how that machinery should work.
As a workaround for releasing 39, I explicitly match on name == "sum" and redirect to the UDAF.
They get a new NullTreatment option.
NullTreatment
I am uncertain about the design choices here, so please be critical.
Even if you choose to release this for v39, let me know how to improve it for next release.
Part of #727 Ref #730
Which issue does this PR close?
Provides python compatibility for
sqlparser::ast::NullTreatmentwhich is now part of the UDAF api.Rationale for this change
AggregateFunction::Sumenum variant is still defined upstream, but can not be used.I suspect that the proper solution is to register the new UDAFs with the function registry. But I'm unsure how that machinery should work.
As a workaround for releasing 39, I explicitly match on name == "sum" and redirect to the UDAF.
Are there any user-facing changes?
They get a new
NullTreatmentoption.Additional Context
I am uncertain about the design choices here, so please be critical.
Even if you choose to release this for v39, let me know how to improve it for next release.