apache / datafusion-python

Apache DataFusion Python Bindings
https://datafusion.apache.org/python
Apache License 2.0
380 stars 78 forks source link

chore: deprecate `select_columns` #911

Closed ion-elgreco closed 1 month ago

ion-elgreco commented 1 month ago

Which issue does this PR close?

What changes are included in this PR?

Are there any user-facing changes?

timsaucer commented 1 month ago

We need to update docs in docs/source/user-guide/common-operations/select-and-filter.rst to no longer user select_columns since it's marked as deprecated

ion-elgreco commented 1 month ago

We need to update docs in docs/source/user-guide/common-operations/select-and-filter.rst to no longer user select_columns since it's marked as deprecated

Noted, will fix it once I'm back

timsaucer commented 1 month ago

These are trivial diffs, so I'll update them and ask @Michael-J-Ward to give a once over. Thank you again for all the PRs!

Michael-J-Ward commented 1 month ago

LGTM!