apache / datafusion-sqlparser-rs

Extensible SQL Lexer and Parser for Rust
Apache License 2.0
2.8k stars 543 forks source link

hive: support for special not expression `!a` and raise error for `a!` factorial operator #1472

Closed wugeer closed 1 week ago

wugeer commented 1 month ago

Closes: https://github.com/apache/datafusion-sqlparser-rs/issues/1471 Closes: https://github.com/apache/datafusion-sqlparser-rs/issues/1473

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11685843065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/hive.rs 1 2 50.0%
src/dialect/postgresql.rs 1 2 50.0%
src/dialect/mod.rs 2 4 50.0%
tests/sqlparser_common.rs 57 63 90.48%
<!-- Total: 68 78 87.18% -->
Totals Coverage Status
Change from base Build 11651598157: -0.006%
Covered Lines: 30567
Relevant Lines: 34195

💛 - Coveralls
wugeer commented 4 weeks ago

@iffyio Thank you for your suggestions—I learned a lot from them, I've resubmitted an updated version of the code. When you have a moment, could you please review it? Thanks!:)

wugeer commented 3 weeks ago

@iffyio Sorry, my oversight caused the code not to be merged. The code has been re-pushed.

wugeer commented 2 weeks ago

@alamb Could you spare some time to review this PR? Thanks! :)