Closed wugeer closed 1 week ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/dialect/hive.rs | 1 | 2 | 50.0% | ||
src/dialect/postgresql.rs | 1 | 2 | 50.0% | ||
src/dialect/mod.rs | 2 | 4 | 50.0% | ||
tests/sqlparser_common.rs | 57 | 63 | 90.48% | ||
<!-- | Total: | 68 | 78 | 87.18% | --> |
Totals | |
---|---|
Change from base Build 11651598157: | -0.006% |
Covered Lines: | 30567 |
Relevant Lines: | 34195 |
@iffyio Thank you for your suggestions—I learned a lot from them, I've resubmitted an updated version of the code. When you have a moment, could you please review it? Thanks!:)
@iffyio Sorry, my oversight caused the code not to be merged. The code has been re-pushed.
@alamb Could you spare some time to review this PR? Thanks! :)
Closes: https://github.com/apache/datafusion-sqlparser-rs/issues/1471 Closes: https://github.com/apache/datafusion-sqlparser-rs/issues/1473