apache / datafusion-sqlparser-rs

Extensible SQL Lexer and Parser for Rust
Apache License 2.0
2.8k stars 543 forks source link

Add support for SHOW DATABASES/SCHEMAS/TABLES/VIEWS in Hive #1487

Closed yoavcloud closed 2 weeks ago

yoavcloud commented 3 weeks ago

This PR adds support for the above statements in the Hive dialect, making the previously MySQL-only structs a bit more generic.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11632792517

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 32 36 88.89%
<!-- Total: 91 95 95.79% -->
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 82.14%
src/dialect/postgresql.rs 2 73.5%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 11580333290: 0.02%
Covered Lines: 30500
Relevant Lines: 34118

💛 - Coveralls
yoavcloud commented 3 weeks ago

Sorry, did a last change and forgot cargo fmt... Changes committed now, if you can run the CI again that would be great @alamb

alamb commented 3 weeks ago

🚀

yoavcloud commented 2 weeks ago

@iffyio @alamb why isn't this merged?

alamb commented 2 weeks ago

@iffyio @alamb why isn't this merged?

Sorry -- am behind.

yoavcloud commented 2 weeks ago

Thank you!