search

apache / datafusion-sqlparser-rs

Extensible SQL Lexer and Parser for Rust
Apache License 2.0
2.81k stars 543 forks source link

Parse true and false as identifiers in mssql #1510

Closed lovasoa closed 1 week ago

lovasoa commented 2 weeks ago

fixes https://github.com/apache/datafusion-sqlparser-rs/issues/1508

lovasoa commented 2 weeks ago

There are 7 failing tests at the moment. From a quick glance, it looks like it's the tests that are incorrect: they rely on the existence of boolean literals in all dialects.

lovasoa commented 2 weeks ago

Ok, I fixed all the tests, this is ready for review @iffyio, @alamb :)

alamb commented 1 week ago

Ci appears to be failing on this PR

lovasoa commented 1 week ago

@alamb : Sorry ! It's fixed now.

alamb commented 1 week ago

🤔 I don't know why but this repo now seems to require manually starting CI. I will look into it

git-hulk commented 1 week ago

@alamb It's the Apache organization's setting behavior if my memory serves. All repositories in the organization are required to manually trigger CI for non-members.

alamb commented 1 week ago

I have filed https://issues.apache.org/jira/browse/INFRA-26268 for trying to ensure CI runs automatically

alamb commented 1 week ago

@alamb It's the Apache organization's setting behavior if my memory serves. All repositories in the organization are required to manually trigger CI for non-members.

Thanks @git-hulk -- arrow and DataFusion both are set to run CI after the first time a contributor has had a PR merged. I filed https://issues.apache.org/jira/browse/INFRA-26268 to request the same setting on this repository (what it used to be as well)