Add support of COMMENT ON syntax for Snowflake

apache / datafusion-sqlparser-rs

Extensible SQL Lexer and Parser for Rust

Apache License 2.0

2.8k stars 543 forks source link

Add support of COMMENT ON syntax for Snowflake #1516

Closed git-hulk closed 1 week ago

git-hulk commented 1 week ago

The COMMENT ON syntax has been supported in PostgreSQL. This PR only moves it into the common and adds supports_comment_on to enable this feature. Also, this PR extends SCHEMA, DATABASE, USER, ROLE as its allowed object type.

This closes #1511.

git-hulk commented 1 week ago

cc @iffyio

alamb commented 1 week ago

It looks like there are some conflicts in this PR that need to be resolved before we can merge it

git-hulk commented 1 week ago

@alamb thanks for your review, ~~will resolve it soon~~ done now.

alamb commented 1 week ago

🚀