apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.34k stars 1.2k forks source link

[TESTS] Fix sqllogictests to support bigdecimal 0.4.3 crate #10001

Open comphead opened 7 months ago

comphead commented 7 months ago

Describe the bug

Since bigdecimal 0.4.3 introduced, there is an display formatting bug leading tests to fail with data type R.

To Reproduce

query R
select 10.0
----
10

External error: query result mismatch:
[SQL] select 10.0
[Diff] (-expected|+actual)
-   1
+   1E+1

Expected behavior

Test should pass on bigdecimal version 0.4.3. It works on current bigdecimal version 0.4.1

Additional context

Related https://github.com/apache/arrow-datafusion/pull/9476

comphead commented 7 months ago

Filed regression https://github.com/akubera/bigdecimal-rs/issues/127