Closed tinfoil-knight closed 7 months ago
@alamb pointed this out while reviewing #9983
https://github.com/apache/arrow-datafusion/blob/ad0abe91752b8da327e97b09d8ca883c782f027d/datafusion/functions/src/math/log.rs#L179
It would be really nice to avoid this clone (I am working to reduce the number of times we need to clone Exprs during planning). see https://github.com/tinfoil-knight/arrow-datafusion/pull/1 for a suggestion
See https://github.com/apache/arrow-datafusion/pull/9983#discussion_r1556233198
Avoid using .clone() wherever possible
.clone()
No response
take
I polished up some code I had and put it up as https://github.com/apache/arrow-datafusion/pull/10086
Is your feature request related to a problem or challenge?
@alamb pointed this out while reviewing #9983
https://github.com/apache/arrow-datafusion/blob/ad0abe91752b8da327e97b09d8ca883c782f027d/datafusion/functions/src/math/log.rs#L179
See https://github.com/apache/arrow-datafusion/pull/9983#discussion_r1556233198
Describe the solution you'd like
Avoid using
.clone()
wherever possibleDescribe alternatives you've considered
No response
Additional context
No response