search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
5.29k stars 973 forks source link

[Epic] Improved TreeNode APIs #10121

Open alamb opened 1 month ago

alamb commented 1 month ago

Is your feature request related to a problem or challenge?

This is a follow on to https://github.com/apache/arrow-datafusion/issues/8913 that tracks additional improvements to the TreeNode API

Describe the solution you'd like

backkem commented 3 weeks ago

The ConcreteTreeNode seems like quite a nice abstraction. Maybe it's interesting to add for the LogicalPlan & Expr as well.

alamb commented 3 weeks ago

The ConcreteTreeNode seems like quite a nice abstraction. Maybe it's interesting to add for the LogicalPlan & Expr as well.

Sounds like a nice idea to me -- I suspect the best way to do so would be to find a usecase that needed / could benefit from the use of that API and refactor the existing code into the (new) API