The root cause for this is that the expression rewrite that happens via TypeCoercionRewriter doesn't return Transformed and thus we must conservatively assume that the schema needs to be recomputed
Describe the solution you'd like
Change TypeCoercionRewriter to return Transformed somehow
Only call LogicalPlan::recompute_schema when the expression is actually transformed
Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/10210 we are trying to make the optimizer faster by making the different optimizer passes faster.
https://github.com/apache/datafusion/pull/10356 avoids a bunch of copies in the TypeCoercion pass
@peter-toth pointed out https://github.com/apache/datafusion/pull/10356/files#r1588892502 that this pass still does more work than necessary as it still always recomputes the schema, even when it didn't make any changes
The root cause for this is that the expression rewrite that happens via
TypeCoercionRewriterdoesn't returnTransformedand thus we must conservatively assume that the schema needs to be recomputedDescribe the solution you'd like
TypeCoercionRewriterto return Transformed somehowLogicalPlan::recompute_schemawhen the expression is actually transformedDescribe alternatives you've considered
No response
Additional context
No response