Open jayzhan211 opened 2 weeks ago
Something we have used to great effect in influxdb is https://insta.rs/
You can then do the equivalent of sqllogictest --complete
(even for results within files) with a command like
cargo insta review
Some downsides are that it is is yet another dependency (and to use it you need to install cargo install cargo-insta
Is your feature request related to a problem or challenge?
While working on #10364, I found that changing the result in the rust test is quite painful.
Currently, we need to fix the string manually one by one
It would be nice if there is an easy way to update the test.
In sqllogictest, we can easily done it with
--complete
flag.Describe the solution you'd like
Given the test, having a very easy way to auto-update result string
Approach 1
One possible solution is writing the result to the file, and comparing it with similar to
sqllogictest
, but since we need to callexpr
API, the API calls remain in the rust test, and only the output goes tooutput file
.Approach 2
Based on https://github.com/apache/datafusion/issues/8736 We can switch between SQL string and
Expr
and compare the result likesqllogictest
doesrun_query
may be likeDescribe alternatives you've considered
No response
Additional context
No response