search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
5.21k stars 957 forks source link

Add more sqllogictests for `parquet_sorted_statistics` #10381

Open yyy1000 opened 2 weeks ago

yyy1000 commented 2 weeks ago

Which issue does this PR close?

Part of #10336 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

yyy1000 commented 2 weeks ago

I think it's better to push this though not finished to get early comments to better modify the code. 😀 Don't know whether I totally understand what https://github.com/apache/datafusion/issues/10336#issuecomment-2094127979 and https://github.com/apache/datafusion/pull/9593#discussion_r1586804068 said. And I'm also learning related code to better understand the background.

alamb commented 1 week ago

I think it's better to push this though not finished to get early comments to better modify the code. 😀

I agree -- thank you @yyy1000 -- I changed the description to reflect this

alamb commented 1 week ago

Thank you @yyy1000 -- I will review this more carefully in the next day or two cc @suremarc