search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
5.29k stars 973 forks source link

Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common #10574

Closed jayzhan211 closed 1 week ago

jayzhan211 commented 2 weeks ago

Which issue does this PR close?

Closes #.

Rationale for this change

  1. add ahash for common, used for distinct count accumulator #10484
  2. move other group accumulator module that is used in aggregate function.
  3. adapter is used in physical plan is not used in aggregate function, so no need to move it.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

jayzhan211 commented 1 week ago

Thanks @alamb

alamb commented 1 week ago

🚀