Verify if DISTINCT supports all types, incl binary, complex, etc

apache / datafusion

Apache DataFusion SQL Query Engine

https://datafusion.apache.org/

Apache License 2.0

5.67k stars 1.06k forks source link

Verify if DISTINCT supports all types, incl binary, complex, etc #11052

Open alamb opened 1 month ago

alamb commented 1 month ago

          Wondering if DISTINCT supports all types, incl binary, complex, etc? if its not we should be mentioning it in the doc, and double check it returns a respective error instead of crash/corruption

_Originally posted by @comphead in https://github.com/apache/datafusion/pull/11012#discussion_r1649198256_

LorrensP-2158466 commented 1 month ago

take

LorrensP-2158466 commented 1 month ago

Questions:

By complex type, you mean like: List, Map, Struct,...?
Do we need to verify if the results are correct, or that we can run DISTINCT on all the data types?

comphead commented 1 month ago

Thanks @LorrensP-2158466 I think we need to write tests for possible combinations and if there is a crash replace it with not_impl_err!, if the result is incorrect we can open an issue and reference this issue next to the failing test

LorrensP-2158466 commented 1 month ago

Ah Okey, I was going in the correct direction, thanks!