search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
5.5k stars 1.02k forks source link

Improve `CommonSubexprEliminate` rule #11194

Open peter-toth opened 4 days ago

peter-toth commented 4 days ago

Is your feature request related to a problem or challenge?

https://github.com/apache/datafusion/pull/10473 improved the identifiers used in CSE but there are a few TODOs left in the code. Let's fix them.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

peter-toth commented 4 days ago

I will open a sequence of PRs to fix the remaining TODOs and some other improvements.

peter-toth commented 4 days ago

cc @alamb